Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scim config endpoint issue#271 #665

Merged
merged 38 commits into from
Feb 2, 2022
Merged

feat: scim config endpoint issue#271 #665

merged 38 commits into from
Feb 2, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Jan 21, 2022

Implemented SCIM config management endpoint
Related issue: #271

@pujavs pujavs requested a review from yuriyz as a code owner January 21, 2022 13:39
yuriyz
yuriyz requested changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@yuriyz yuriyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check inlined comments

jans-config-api/plugins/scim-plugin/dependency-reduced-pom.xml Outdated Show resolved Hide resolved
...ugin/src/main/java/io/jans/configapi/plugin/scim/configuration/ScimConfigurationFactory.java Outdated Show resolved Hide resolved
...ugin/src/main/java/io/jans/configapi/plugin/scim/configuration/ScimConfigurationFactory.java Outdated Show resolved Hide resolved
...ugin/src/main/java/io/jans/configapi/plugin/scim/configuration/ScimConfigurationFactory.java Outdated Show resolved Hide resolved
...im-plugin/src/main/java/io/jans/configapi/plugin/scim/model/config/ScimAppConfiguration.java Outdated Show resolved Hide resolved
...-api/server/src/main/java/io/jans/configapi/security/service/OpenIdAuthorizationService.java Outdated Show resolved Hide resolved
jans-config-api/server/src/main/java/io/jans/configapi/util/AuthUtil.java Outdated Show resolved Hide resolved
jans-config-api/server/src/main/java/io/jans/configapi/util/AuthUtil.java Outdated Show resolved Hide resolved
jans-config-api/server/src/main/java/io/jans/configapi/util/AuthUtil.java Outdated Show resolved Hide resolved
jans-config-api/shared/src/main/java/io/jans/configapi/core/util/Jackson.java Outdated Show resolved Hide resolved
@pujavs pujavs requested a review from yuriyz January 25, 2022 12:08
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2022

[jans-pycloudlib] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability D 5 Vulnerabilities
Security Hotspot E 11 Security Hotspots
Code Smell A 29 Code Smells

0.0% 0.0% Coverage
4.2% 4.2% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2022

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2022

[notify] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

[orm] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
a000853 
…ns-config-api-issue-271
@pujavs
feat: sonar issue
bd21232
@pujavs
feat: sonar issue
dc7d745
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
0131e86 
…ns-config-api-issue-271
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
a4d49fd 
…ns-config-api-issue-271
@pujavs
feat: scim config endpoint changes to resolve sonar issue
a7f9e53
@pujavs
feat: scim config endpoint changes to resolve sonar issue
e29a4b3
@pujavs
feat: scim config endpoint changes to resolve sonar issue
4ea1540
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
d460598 
…ns-config-api-issue-271
@pujavs
feat: scim config endpoint
340c38a
@pujavs
feat: scim config endpoint sonar issue
3217b86
@pujavs
feat: scim config endpoint sonar issue
8d6adb7
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
a7d6576 
…ns-config-api-issue-271
@pujavs
feat: scim config endpoint sonar issue
60ab2f2
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

[jans-client-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujavs
Copy link
Contributor Author

pujavs commented Feb 2, 2022

@yuriyz, request you to please review and share your feedback.

@yuriyz yuriyz merged commit a6e9a04 into main Feb 2, 2022
@yuriyz yuriyz deleted the jans-config-api-issue-271 branch February 2, 2022 09:04
This was referenced Feb 14, 2022
Closed
Closed
Closed
@mo-auto mo-auto mentioned this pull request Mar 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pujavs @yuriyz