Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow version pass to avoid latest install always #8517

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

misba7
Copy link
Contributor

@misba7 misba7 commented May 15, 2024

closes #8513

Signed-off-by: Amro Misbah <amromisba7@gmail.com>
@misba7 misba7 requested review from moabu and iromli as code owners May 15, 2024 12:24
@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality labels May 15, 2024
@@ -2,10 +2,10 @@
set -eo pipefail
JANS_FQDN=$1
JANS_PERSISTENCE=$2
JANS_CI_CD_RUN=$3
JANS_VERSION=$3
Copy link
Contributor

@iromli iromli May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misba7 What's the default JANS_VERSION?

@@ -242,7 +239,7 @@ auth-server:
EOF
sudo helm repo add janssen https://docs.jans.io/charts
sudo helm repo update
sudo helm install janssen janssen/janssen -n jans -f override.yaml --kubeconfig="$KUBECONFIG" "$HELM_DEVELOPMENT_REPO"
sudo helm install janssen janssen/janssen -n jans -f override.yaml --kubeconfig="$KUBECONFIG" --version="$JANS_VERSION"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misba7 have we handle empty $JANS_VERSION?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty JANS_VERSION installs latest, which was the default behavior.
I added the variable to be able to override it as needed.

Copy link
Contributor

@iromli iromli May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean command like helm install --version= (empty JANS_VERSION) also work?

Copy link
Contributor

@iromli iromli May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore my last comment, i have tested it. The --version= <other-ops> is working while --version <other-ops> is not.

Copy link

dryrunsecurity bot commented Jul 11, 2024

DryRun Security Summary

The changes in the startjanssendemo.sh file aim to improve the deployment and configuration options for the Janssen IAM platform, including support for different persistence types, version selection, Istio integration, and customizable logging, providing more flexibility and security-conscious features for the Janssen deployment.

Expand for full summary

Summary:

The code changes in the startjanssendemo.sh file are focused on improving the deployment and configuration
options for the Janssen application, an open-source identity and access management (IAM) platform. The key
changes include support for different persistence types (LDAP, MySQL, PostgreSQL), the ability to specify
the Janssen version, integration with the Istio service mesh, and customizable logging configurations.

From an application security perspective, these changes are generally positive, as they provide more
flexibility and security-conscious features for the Janssen deployment. The support for different persistence
types allows the deployment to be tailored to the specific requirements of the environment, while the logging
configuration options help control the exposure of sensitive information. The integration with Istio can also
provide additional security benefits, such as mutual TLS (mTLS) between services, traffic monitoring, and
access control. However, it's important to ensure that the database credentials and configurations are properly
secured, especially for the MySQL and PostgreSQL options, and that Istio is properly configured and maintained
to maximize the security benefits.

Files Changed:

  • automation/startjanssendemo.sh: This script has been updated to support different persistence types
    for the Janssen application, including LDAP, MySQL, and PostgreSQL. The user is prompted to enter the
    desired persistence type, and the script generates the appropriate configuration. The script also allows
    the user to specify the version of the Janssen application to be deployed, integrates with the Istio
    service mesh, and sets up customizable logging configurations for various Janssen components.

Code Analysis

We ran 7 analyzers against 1 file and 0 analyzers had findings. 7 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@moabu moabu merged commit 2bce686 into main Jul 11, 2024
9 of 13 checks passed
@moabu moabu deleted the fix-jans-script branch July 11, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: startjanssendemo script always install latest
4 participants