-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow version pass to avoid latest install always #8517
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,10 +2,10 @@ | |
set -eo pipefail | ||
JANS_FQDN=$1 | ||
JANS_PERSISTENCE=$2 | ||
JANS_CI_CD_RUN=$3 | ||
JANS_VERSION=$3 | ||
EXT_IP=$4 | ||
INSTALL_ISTIO=$5 | ||
HELM_DEVELOPMENT_REPO=$6 | ||
JANS_CI_CD_RUN=$5 | ||
INSTALL_ISTIO=$6 | ||
if [[ ! "$JANS_FQDN" ]]; then | ||
read -rp "Enter Hostname [demoexample.jans.io]: " JANS_FQDN | ||
fi | ||
|
@@ -21,9 +21,6 @@ if [[ $JANS_PERSISTENCE != "LDAP" ]] && [[ $JANS_PERSISTENCE != "MYSQL" ]] && [[ | |
echo "[E] Incorrect entry. Please enter either LDAP, MYSQL or PGSQL" | ||
exit 1 | ||
fi | ||
if [[ ! "$HELM_DEVELOPMENT_REPO" ]]; then | ||
HELM_DEVELOPMENT_REPO="" | ||
fi | ||
|
||
LOG_TARGET="FILE" | ||
LOG_LEVEL="TRACE" | ||
|
@@ -242,7 +239,7 @@ auth-server: | |
EOF | ||
sudo helm repo add janssen https://docs.jans.io/charts | ||
sudo helm repo update | ||
sudo helm install janssen janssen/janssen -n jans -f override.yaml --kubeconfig="$KUBECONFIG" "$HELM_DEVELOPMENT_REPO" | ||
sudo helm install janssen janssen/janssen -n jans -f override.yaml --kubeconfig="$KUBECONFIG" --version="$JANS_VERSION" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @misba7 have we handle empty There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. empty JANS_VERSION installs latest, which was the default behavior. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did you mean command like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ignore my last comment, i have tested it. The |
||
|
||
wait_for_services jans-config-api/api/v1/health/ready | ||
wait_for_services jans-scim/sys/health-check | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misba7 What's the default
JANS_VERSION
?