Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Added instuctions on building a docker image from dist #1315

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

chupman
Copy link
Member

@chupman chupman commented Nov 8, 2018

I was building the container while reviewing a PR and thought it would be great to include instructions on how to use a release distribution since it can be a lot faster.
I also brought in the update from this commit since I think it should have been targeted at the 0.2 branch originally.

Signed-off-by: Chris Hupman chupman@us.ibm.com


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?
  • If this PR is a documentation-only change, have you added a [skip ci]
    tag to the first line of your commit message to avoid spending CPU cycles in
    Travis CI when no code, tests, or build configuration are modified?

Note:

Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.

@janusgraph-bot janusgraph-bot added the cla: yes This PR is compliant with the CLA label Nov 8, 2018
Copy link
Member

@FlorianHockmann FlorianHockmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, I just commented on two nits. Although I'm not sure whether someone wants to build a Docker image of an existing release once we have an official Docker image (JanusGraph/janusgraph-docker#1). But we can still merge this for now and then decide later on what we do with these image in the main repo (like using it only for testing of other components).

BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
Signed-off-by: Chris Hupman <chupman@us.ibm.com>
@chupman chupman merged commit 7ab60af into JanusGraph:0.2 Dec 14, 2018
@FlorianHockmann FlorianHockmann added this to the Release v0.2.3 milestone Feb 28, 2019
micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019
[skip ci] Added instuctions on building a docker image from dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This PR is compliant with the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants