Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2833 #2834

Conversation

mmarovic
Copy link
Contributor

@mmarovic mmarovic commented Oct 5, 2021

Fixes #2833

Signed-off-by: Mladen Marović mladen.marovic@gmail.com


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Oct 5, 2021
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you retarget this PR against v0.6 branch? We would like to release this fix in 0.6.1 version. Thank you!

Signed-off-by: Mladen Marović <mladen.marovic@gmail.com>
@mmarovic mmarovic force-pushed the fix-2833-disable-list-parsing-in-new-graph-config branch from 12f16ee to bd3242e Compare October 12, 2021 13:52
@mmarovic mmarovic changed the base branch from master to v0.6 October 12, 2021 13:53
@li-boxuan li-boxuan merged commit 8034afd into JanusGraph:v0.6 Oct 22, 2021
@li-boxuan
Copy link
Member

Merged by following lazy consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
None yet
3 participants