Issue 398 - CQL storage adapter doesn't work with default configs and bundled Cassandra #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bundled Cassandra If no protocol is specified, the CQL driver no longer defaults to the highest driver protocol version. Instead, the driver will negotiate with Cassandra and select the highest mutually supported protocol version.
sjudeng
approved these changes
Jul 7, 2017
|
Let me run through TinkerPop tests once before merging (unless you already did). Also @samant-orionhealth / @pkendall64 please let us know if you see any issue with this. |
|
Yes, that looks good. It's better that it negotiate than use the highest in the driver because that's newer than the cassandra that you can connect to. |
|
Thanks @pkendall64. All TinkerPop tests passed as well. I thought it was worth checking given the "if we let it negotiate then there are spurious errors" comment in the code. |
|
Fixes issue #398 |
|
Thanks for the TinkerPop and extra C* version testing @sjudeng |
bwatson-rti-org
pushed a commit
to bwatson-rti-org/janusgraph
that referenced
this pull request
Mar 9, 2019
Issue 398 - CQL storage adapter doesn't work with default configs and bundled Cassandra
micpod
pushed a commit
to micpod/janusgraph
that referenced
this pull request
Nov 5, 2019
Issue 398 - CQL storage adapter doesn't work with default configs and bundled Cassandra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no protocol is specified, the CQL driver no longer defaults to the highest driver
protocol version. Instead, the driver will negotiate with Cassandra and select the
highest mutually supported protocol version.