Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add - Words] companies.txt and fullstack.txt #53

Merged
merged 4 commits into from
Apr 20, 2019
Merged

[Add - Words] companies.txt and fullstack.txt #53

merged 4 commits into from
Apr 20, 2019

Conversation

rbalet
Copy link
Contributor

@rbalet rbalet commented Mar 6, 2019

Add words in fullstack + update version.

For companies.txt,

  • add: Gitlab, verdaccio
  • remove duplicate: Linkedin
  • reorder file

Also regenerate .gz files

Copy link
Contributor

@d2s d2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some potential details to improve.

@@ -368,6 +368,7 @@ Genworth Financial, Inc.
George Weston
GeoTrust Global
Gilead Sciences, Inc.
Gitlab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelling, the official version of the name is: GitLab
(with big L character).

LinkedIn
linkedin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate item.

classlist
codelyzer
collapsable
compat
cond
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there reason why cond was removed?
Was it a misspelling of conda or is there another reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, I'll fix that. Thx for the feedback

Copy link
Contributor Author

@rbalet rbalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fix the error you spotted :)

classlist
codelyzer
collapsable
compat
cond
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, I'll fix that. Thx for the feedback

@Jason3S Jason3S merged commit 9a5ee29 into streetsidesoftware:master Apr 20, 2019
@Jason3S
Copy link
Collaborator

Jason3S commented Apr 20, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants