Add HTTP request as well as response logging #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create type aliases for headers and params * call log block before the request * call log block after response * remove default logger, add log examples to README
| @@ -215,28 +214,7 @@ public struct CRUDE { | |||
| return NSError(domain: issue, code: (network.response?.statusCode ?? -1), userInfo: debugInfo) | |||
| } | |||
|
|
|||
| private static var defaultLogger: CRUDELog = { type, network in | |||
There was a problem hiding this comment.
@jjulian Is there a reason why the defaultLogger feature was removed?
There was a problem hiding this comment.
Logging is very app-specific. If the client wants to log, they can easily use or modify the example code.
There was a problem hiding this comment.
The default logger was a requested feature I added. While I will agree that different developer teams will have different logging preferences, an option to use a pre-baked one does no harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not vital for the OrderUp app. I'm using it locally to debug, but I don't need to upgrade the app to use this code until you've reviewed it and are happy with it.