Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Signale logger #45

Merged
merged 21 commits into from
Feb 16, 2019
Merged

Add Signale logger #45

merged 21 commits into from
Feb 16, 2019

Conversation

JasonEtco
Copy link
Owner

@JasonEtco JasonEtco commented Feb 13, 2019

Why?

This PR adds Signale, a really nice logging utility that comes with a great looking output in the Actions UI. Here's a screenshot:

Code Screenshot
image

This is accessible as tools.log:

tools.log('Log a thing!')
tools.log.info('Log something else!')

Closes #5

How?

I've basically just exported an instance of Signale, with the underlineLabel option disabled - in my testing, this was the difference between the above nice image and a huge whitespace area. The underline wouldn't render anyway, so it was causing issues 🤷‍♂️


  • Tests have been added/updated (if necessary)
  • Documentation has been updated (if necessary)

@JasonEtco
Copy link
Owner Author

JasonEtco commented Feb 14, 2019

Worked on some docs, here it is rendered:

image

This is totally shippable right now, but I'd love to try to get tools.log() to work as a method (technically a callable class) - it'd basically work like:

const logger = new Signale()
tools.log = logger.info
Object.assign(tools.log, logger)

I'm certain that TypeScript will give me heck for that though. Added in b6f05bc!

@JasonEtco JasonEtco merged commit a3e4da8 into master Feb 16, 2019
@JasonEtco JasonEtco deleted the signale branch February 16, 2019 18:20
@JasonEtco JasonEtco mentioned this pull request Mar 22, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant