This repository has been archived by the owner on Jan 15, 2022. It is now read-only.
Use Joi to validate configs #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 98.63% 98.63% +<.01%
==========================================
Files 23 23
Lines 219 220 +1
Branches 45 45
==========================================
+ Hits 216 217 +1
Misses 2 2
Partials 1 1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Joi schema to validate the config options that are set by repository. Followup PRs will include autogenerating docs from this, adding more tests to the new
main-loop.test.jssuite, and notifying users when they've pushed invalid configs; but for now this'll do.