Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeMKV never starts #69

Closed
cyberhiker opened this issue Feb 19, 2015 · 17 comments
Closed

makeMKV never starts #69

cyberhiker opened this issue Feb 19, 2015 · 17 comments
Assignees
Labels
Milestone

Comments

@cyberhiker
Copy link

This is a clean, new install of a headless Ubuntu 14.04 instance with the --test running successfully. I am using makeMKV version 1.9.1 and I am getting the following error from the debug output:

2015-02-19 14:36:26 - Rip - DEBUG - Ripping initialised
2015-02-19 14:36:26 - Rip - DEBUG - Checking for DVDs
2015-02-19 14:36:30 - Rip - DEBUG - 1 DVDs found
2015-02-19 14:36:46 - Makemkv - DEBUG - MakeMKV found 1 titles
Traceback (most recent call last):
  File "autorippr.py", line 317, in <module>
    rip(config)
  File "autorippr.py", line 155, in rip
    database.update_movie(dbMovie, 3, mkv_api.get_savefile())
  File "/home/chris/Autorippr/classes/makemkv.py", line 298, in get_savefile
    return self.saveFile
AttributeError: 'makeMKV' object has no attribute 'saveFile'

MakeMKVcon seems to run fine when I do makemkvcon info disk:0 but I don't know enough to provide anymore with out guidance.

Let me know if you need something else to help track this down further.

@JasonMillward
Copy link
Owner

Interesting, it looks like it's not reaching line 289.

What branch are you using? If you're using 1.6 can you check master and try again?

@cyberhiker
Copy link
Author

I'm on the 1.6 master.

@JasonMillward
Copy link
Owner

You can't be on both, you're either on v1.6 or on master.

What does git branch tell you?

@tjordan170
Copy link

I'm having the same problem. Any thoughts?

git branch

  • (detached from v1.6)

When i switch to master I get:
2015-02-21 22:16:50 - Rip - DEBUG - Ripping initialised
Traceback (most recent call last):
File "autorippr.py", line 329, in
rip(config)
File "autorippr.py", line 123, in rip
mkv_api = makemkv.makeMKV(config)
File "/home/thomas/Downloads/ffmpeg-2.5.4/Autorippr/classes/makemkv.py", line 31, in init
self.makemkvconPath = config['makemkv']['makemkvconPath']
KeyError: 'makemkvconPath'

@JasonMillward
Copy link
Owner

Hmm, git seems to be confusing the issue slightly.

See if you can switch to the proper master

git checkout master

Then run git branch again, it should look something like this, with no mention of v1.6:

$ git branch
* master

File "/home/thomas/Downloads/ffmpeg-2.5.4/Autorippr/classes/makemkv.py", line 31, in init
self.makemkvconPath = config['makemkv']['makemkvconPath']

Update your settings.cfg, you're missing some new settings.

@cyberhiker
Copy link
Author

Same. I'm on master and did a pull. Same issue. 

I can give you SSH access to my box for you to debug. 

-C

On Sat, Feb 21, 2015 at 10:23 PM, Jason notifications@github.com wrote:

Hmm, git seems to be confusing the issue slightly.
See if you can switch to the proper master
git checkout master
Then run git branch again, it should look something like this:
$ git branch

* master

Reply to this email directly or view it on GitHub:
#69 (comment)

@JasonMillward
Copy link
Owner

I'd rather not have access to your box right now.

Let me make some changes first, and if all else fails I'll take you up on your offer.

@cyberhiker
Copy link
Author

What's the word? Need any help with anything?

@JasonMillward
Copy link
Owner

My apologies, some family matters distracted me.

Can you please checkout branch issue-69 and run using python autorippr.py --debug --rip

There are some new debug options and I'm interested in this part;

2015-03-06 11:07:36 - Makemkv - DEBUG - MakeMKV found 1 titles
2015-03-06 11:07:36 - Makemkv - DEBUG - Title number: 0
2015-03-06 11:07:36 - Makemkv - DEBUG - ['Totally a movie']
2015-03-06 11:07:36 - Makemkv - DEBUG - MakeMKV title info: ['title00.mkv']
2015-03-06 11:07:36 - Makemkv - DEBUG - saveFile returned: 'title00.mkv'

@JasonMillward JasonMillward self-assigned this Mar 6, 2015
@JasonMillward JasonMillward added this to the v1.7 milestone Mar 6, 2015
@cyberhiker
Copy link
Author

I know all about family commitments and totally understand. I have a set of two yo twins and a 4 mo old.

Here you go:

2015-03-05 21:16:52 - Rip - DEBUG - Ripping initialised
2015-03-05 21:16:52 - Rip - DEBUG - Checking for DVDs
2015-03-05 21:16:57 - Rip - DEBUG - 1 DVDs found
2015-03-05 21:17:13 - Makemkv - DEBUG - MakeMKV found 1 titles
2015-03-05 21:17:13 - Makemkv - DEBUG - saveFile returned: ''
2015-03-05 21:17:29 - Makemkv - ERROR - MakeMKV (rip_disc) returned status code: 11
2015-03-05 21:17:29 - Makemkv - ERROR - Profile parsing error: default profile missing, using builtin default
2015-03-05 21:17:29 - Rip - INFO - MakeMKV did not did not complete successfully
2015-03-05 21:17:29 - Rip - INFO - See log for more details
2015-03-05 21:17:29 - Rip - DEBUG - Movie title: Rock And Roll

@JasonMillward
Copy link
Owner

Okay, your disc doesn't seem to be showing any TINFO messages.

What output do you get when you run grep "TINFO" /tmp/makemkvMessages ?

@cyberhiker
Copy link
Author

Nothing. No output. Tried it with and without quotes.

@JasonMillward
Copy link
Owner

This is strange, MakeMKV is not returning any title info from your disc, but it thinks it finds 1 title.

What do these give?

grep "added" /tmp/makemkvMessages

grep "TCOUNT" /tmp/makemkvMessages

@cyberhiker
Copy link
Author

~$ grep "added" /tmp/makemkvMessages
~$ grep "TCOUNT" /tmp/makemkvMessages

TCOUNT:0

@JasonMillward
Copy link
Owner

Fantastic! I have found the issue and should have a fix shortly.

JasonMillward added a commit that referenced this issue Mar 6, 2015
@JasonMillward
Copy link
Owner

Can you pull the changes from issue-69 and run again using python autorippr.py --debug --rip

If I found the right issue, it should not crash any more and instead return a nice message.

@cyberhiker
Copy link
Author

Excellent. It is all working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants