Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remember to drop releases #37

Open
drAlberT opened this issue Sep 1, 2017 · 6 comments
Open

Please remember to drop releases #37

drAlberT opened this issue Sep 1, 2017 · 6 comments

Comments

@drAlberT
Copy link
Contributor

drAlberT commented Sep 1, 2017

:) thanks

@drAlberT
Copy link
Contributor Author

drAlberT commented Sep 6, 2017

Just to clarify, on GitHub I mean ..

@JasonRivers
Copy link
Owner

I actually switched to branches for this, Branches mean that if there's a problem it can be fixed, but perhaps creating a tag/release at that branch is a good way of doing it.

@drAlberT
Copy link
Contributor Author

yep :) branches and tags/releases are complementary 👍

@drAlberT
Copy link
Contributor Author

Anyway .. I think you are adopting a too expensive model to handle the code

My suggestion is to have only a few branches (master, version X, version Y) in which you do:

  • development
  • maintain X.x.x releases
  • maintain Y.y.y releases

You can add (only if and when requested) additional X.Z.z branches . in case you want to support that particular minor release releasing patches for it but, in general you would only maintain a few main branches, tagging on it the releases.

Everytime you release a new patch (in the semver meaning) you drop a new release (tagging it)

example:

  • master -> development of the latest features
  • branch 4.x -> stable branch for version 4.x.x (it requires php 7.x)
  • branche 3.x -> stable branch for version 3.x.x (it requires and supports php 5.x)

Hope to had been clear .. hope to not be boring or annoying too ;)

@JasonRivers
Copy link
Owner

You are probably right, The reason for having docker hub builds of the version (as either a branch or a tag) was for the users that don't want to upgrade to the latest version all the time "just in case".

I probably won't ever maintain a Nagios3, the reason I created this image was that everything I found at the time was either Nagios3 or didn't really work, But I will probably continue to maintain "the latest nagios4" when Nagios 5 drops, at least for a while.

Overall, it doesn't actually take a lot of maintenance, Both dockerhub and Travis build when I commit and tell me when I'm being a muppet, and I generally build and deploy to a test environment before committing to master.

I haven't committed to any of versioned branches for a while, I can probably just create tags for those now, and as you say, maintain a 4.x branch instead.

Thanks for your input.

@drAlberT
Copy link
Contributor Author

drAlberT commented Oct 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants