-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remember to drop releases #37
Comments
Just to clarify, on GitHub I mean .. |
I actually switched to branches for this, Branches mean that if there's a problem it can be fixed, but perhaps creating a tag/release at that branch is a good way of doing it. |
yep :) branches and tags/releases are complementary 👍 |
Anyway .. I think you are adopting a too expensive model to handle the code My suggestion is to have only a few branches (master, version X, version Y) in which you do:
You can add (only if and when requested) additional X.Z.z branches . in case you want to support that particular minor release releasing patches for it but, in general you would only maintain a few main branches, tagging on it the releases. Everytime you release a new patch (in the semver meaning) you drop a new release (tagging it) example:
Hope to had been clear .. hope to not be boring or annoying too ;) |
You are probably right, The reason for having docker hub builds of the version (as either a branch or a tag) was for the users that don't want to upgrade to the latest version all the time "just in case". I probably won't ever maintain a Nagios3, the reason I created this image was that everything I found at the time was either Nagios3 or didn't really work, But I will probably continue to maintain "the latest nagios4" when Nagios 5 drops, at least for a while. Overall, it doesn't actually take a lot of maintenance, Both dockerhub and Travis build when I commit and tell me when I'm being a muppet, and I generally build and deploy to a test environment before committing to master. I haven't committed to any of versioned branches for a while, I can probably just create tags for those now, and as you say, maintain a 4.x branch instead. Thanks for your input. |
great. Mind the fact that if you choose to switch to tag you should tag
**master** branch at the point you created the matching release branch, not
just tag the release branch directly.
Thanks for your work
…On Monday, October 16, 2017, Jason Rivers ***@***.***> wrote:
You are probably right, The reason for having docker hub builds of the
version (as either a branch or a tag) was for the users that don't want to
upgrade to the latest version all the time "just in case".
I probably won't ever maintain a Nagios3, the reason I created this image
was that everything I found at the time was either Nagios3 or didn't really
work, But I will probably continue to maintain "the latest nagios4" when
Nagios 5 drops, at least for a while.
Overall, it doesn't actually take a lot of maintenance, Both dockerhub and
Travis build when I commit and tell me when I'm being a muppet, and I
generally build and deploy to a test environment before committing to
master.
I haven't committed to any of versioned branches for a while, I can
probably just create tags for those now, and as you say, maintain a 4.x
branch instead.
Thanks for your input.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYDjJfA7jywzeoWcFuCW3wgCLJWpbLdks5ssx85gaJpZM4PKKVm>
.
--
Emiliano Gabrielli
|
:) thanks
The text was updated successfully, but these errors were encountered: