Skip to content

Commit

Permalink
Opening keyboard shortcuts UI result in "destruction" of shortcut set…
Browse files Browse the repository at this point in the history
…tings (jupyterlab#12112)

* Opening keyboard shortcuts UI result in "destruction" of shortcut settings
Fixes jupyterlab#12056

* Prettify
  • Loading branch information
fcollonval authored and JasonWeill committed Mar 2, 2022
1 parent 9718b66 commit 1eaa919
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion packages/settingregistry/src/settingregistry.ts
Expand Up @@ -1162,7 +1162,15 @@ export namespace SettingRegistry {
});

// Return all the shortcuts that should be registered
return user.concat(defaults).filter(shortcut => !shortcut.disabled);
return (
user
.concat(defaults)
.filter(shortcut => !shortcut.disabled)
// Fix shortcuts comparison in rjsf Form to avoid polluting the user settings
.map(shortcut => {
return { args: {}, ...shortcut };
})
);
}

/**
Expand Down

0 comments on commit 1eaa919

Please sign in to comment.