-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcasters #2314
Merged
Merged
Upcasters #2314
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ca83b17
Added initial JSON transformation serializer wrapper
oskardudycz c500472
Defined first version of public API for Upcasters
oskardudycz 58b5a39
Addes Upcasters sample
oskardudycz 50e4bcb
Merged Json transformations to simplify processing
oskardudycz 80bb4cd
Removed JsonTransformations leaving only what's currently needed
oskardudycz 1f77e03
Added Event Upcasters classes and updated samples
oskardudycz 5690a20
Added JsonNet Upcasters implementation
oskardudycz f7d2162
Merged CLR typed upcasters into one as there's no need for parallel i…
oskardudycz 4fefe43
Added some synctactic sugar to allow easier upcasting by clr types wi…
oskardudycz 874bc61
Added Asynchronous Upcasters. Cleaned up Task/ValueTask usage in Json…
oskardudycz b7bcb74
Made EventMappingExtensions internal. Dropped `Set` prefix from SetEv…
oskardudycz a10770b
Updated public API docs for Upcasters
oskardudycz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremydmiller, maybe it would be worth grouping those transformations into nested property instead of adding them straight into
EventGraph
? E.g.options.Events.Transformations.Upcast(...)
. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but that's a lot of dots and not super discoverable. I think I'd leave it on
EventGraph
, but maybe look at what could be hidden or simplified in v6.It's not a precise rule by any stretch of the imagination, but I think you try to limit the number of navigation dots or nested closure levels to two in configuration code like this. I don't have a super strong opinion about this though.