Fix wrong session-tenacity used in Custom Aggregation Projections #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haefele
changed the title
|
@haefele, thank you a lot for the contribution. Nicely tracked! I missed the custom projection while working on #2497.
I think that we should be fine, as the rest of the projections either derive from Would you like me to do a quick release with this fix, or there's no urgency? |
|
No need for a extra release. Whenever the next one comes out is fine 😁 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR #2497 applying the method
UseTenancyBasedOnSliceAndStoragealso when usingCustom Aggregation Projections, instead of only toSingle Stream Projections.This fixes the issue described in #2363 (comment).
There are some additional issues described in this other comment #2363 (comment).
I think those should be fixed now too. The aggregate document is now always loaded using the correct tenant session (see Single Stream Aggregations here and Custom Aggregation Projections in this PR right now).
Are there any other projections that would need this code-fix?