-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled the possibility of applying projections with different Conjoined Tenancy scopes for projections. #2497
Conversation
eb41cf4
to
300eb5e
Compare
@oskardudycz I think the approach is fine, but I'm still saying we should isolate that one method that determines how to get the session and test the crap out of the permutations. Maybe change the signature so you can "push" the DocumentMapping/IDocumentStorage, parent session, and EventSlice. Might even move the logic to EventSlice itself to clean things up a little bit. |
e922167
to
1da8a2e
Compare
@oskardudycz there looks to be a failing test |
Yes, it's a blinking test. Not related to the changes. |
@jeremydmiller, I applied your suggestion 👍 |
@oskardudycz I'm reviewing this again finally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking that. That one was nasty.
…main session to enable conjoined tenancy processing for projections
Thanks, @jeremydmiller, for reviewing it; indeed, it was tricky. I had to spend some time writing on paper all those permutations 😅 |
Summary
SingleTenanted
option) when the global convention is to have multi-tenanted.Scenarios
Plus permutations related to:
session.SessionOptions.AllowAnyTenant
session.Options.Advanced.DefaultTenantUsageEnabled
session.DocumentStore.Options.Tenancy.IsTenantStoredInCurrentDatabase
Fixes #2363
Note: Suggested review with whitespace hidden https://github.com/JasperFx/marten/pull/2497/files?diff=split&w=1.