Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update: Custom Projection -> Custom Aggregations to avoid duplicate entry #2774

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

gfoidl
Copy link
Contributor

@gfoidl gfoidl commented Nov 11, 2023

grafik

Updated the entry in the TOC to match the title of the page.

@gfoidl
Copy link
Contributor Author

gfoidl commented Nov 11, 2023

Spell check failed with

ApplicationError: Unsupported NodeJS version (16.20.2); >=18 is required
    at Module.run (file:///opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/cspell/dist/esm/app.mjs:17:15)
    at file:///opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/cspell/bin.mjs:6:5
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12) {
  exitCode: 1,
  cause: undefined

So I updated Node to 18.x in 6231402

Copy link
Member

@mysticmind mysticmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mysticmind mysticmind merged commit 9199350 into JasperFx:master Nov 17, 2023
12 of 13 checks passed
@gfoidl gfoidl deleted the doc-updates branch November 17, 2023 13:46
@gfoidl
Copy link
Contributor Author

gfoidl commented Nov 17, 2023

Cool, it's already online 🚀

@mysticmind mysticmind added this to the 6.3.1 milestone Nov 17, 2023
@oskardudycz oskardudycz modified the milestones: 6.3.1, 6.4.0 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants