Applied EditorBrowsable to now obsoleted aggregation types #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spell-check fails with the same error as #2774 (comment) Can we either bring the other PR in or have a separate PR to update the spell-check to Node 18? |
|
@gfoidl I will have a look shortly and sort out the spell-check stuff. |
|
The spell-check is basically just 647a25b |
I know, have fixed the spell checker one which is failing. Please rebase your PR with master, it should be fine. |
mysticmind
approved these changes
Nov 17, 2023
gfoidl
force-pushed
the
editor-browsable
branch
from
e2ab45b
to
1f79c8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2773
Please see description in the issue for the rationale for this change.