This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Multiplication error fix and additional tests for the add method of FastMoney #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiplyExact Method
joe-bookwood
changed the title
|
Thanks for your contribution. Thanks |
|
We don't need to put this PR to RI, because RI uses the new Java 8 Math.multiplyExact method. Please tell me when you plan to deploy a new release with this fix to maven central. |
|
Thanks. |
|
In Moneta-BP there needs to be an equivalent to multiplyExact! |
|
@keilw my fix repair the multiplyExact equivalent method, because this method does not exist Java 7. If you multiply x with zero you got x and not zero, if you use the current version 1.0 or 1.1 from maven central. This is the error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.