Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWG cash rounding is not supported #407

Closed
Testsubject1683 opened this issue Feb 26, 2024 · 5 comments
Closed

AWG cash rounding is not supported #407

Testsubject1683 opened this issue Feb 26, 2024 · 5 comments

Comments

@Testsubject1683
Copy link
Contributor

Arubian Florin has 5 cents as the smallest denomination. Currently Moneta has no special handling for cash rounding with AWG.
I already created a PR which should fix it #405

@sschuerz
Copy link

Is there a chance to get this fixed timely?

@sschuerz
Copy link

Is there a chance to timely get a release including the change?

@keilw
Copy link
Member

keilw commented Apr 25, 2024

@sschuerz Could you test it in the 1.4.5-SNAPSHOT build?
We still have a few issues to solve: https://github.com/JavaMoney/jsr354-ri/milestone/11
Of those only #413 is negotiable, because it mainly affects testing, we could shift it to 1.5 or 1.4.6, the others need to be resolved before we do a new release.

@sschuerz
Copy link

sschuerz commented May 9, 2024

@keilw Sorry for the late response.
I think testing with a snapshot version on our side is not required since it is quite clear what the effect of the change will be.
And as we cannot productively use the snapshot version, I think we will have to wait for the final 1.4.5 release.
Thanks anyway!

@keilw
Copy link
Member

keilw commented Sep 7, 2024

Is already merged.

@keilw keilw closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants