Remove unnecessary boxing #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tests contain code that can be simplified using autoboxing.
stokito
reviewed
Dec 30, 2018
| @@ -43,7 +43,7 @@ public void shouldExchangeCurrencyPositiveValue() { | |||
| MonetaryAmount result = ConversionOperators.exchange(real).apply(money); | |||
| assertNotNull(result); | |||
| assertEquals(result.getCurrency(), real); | |||
| assertEquals(Double.valueOf(2.35), result.getNumber().doubleValue()); | |||
| assertEquals(2.35d, result.getNumber().doubleValue()); | |||
There was a problem hiding this comment.
maybe it's better to make the d literal in uppercase for consistency with L for longs
There was a problem hiding this comment.
Would you do this across the entire code base? Also for floats?
There was a problem hiding this comment.
I can't say that this is correct style and I guess this should be decided by the project leaders.
But actually I would like to rise another point: most asserEquals() by the Double are checking an amount so maybe we can simplify to make an equals my MonetaryAmount ie.
assertEquals(result, Money.of(2.35, "USD");
stokito
approved these changes
Dec 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tests contain code that can be simplified using autoboxing.
This change is