Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCUP search by numeric currency code #310

Merged
merged 1 commit into from Aug 7, 2019
Merged

CCUP search by numeric currency code #310

merged 1 commit into from Aug 7, 2019

Conversation

marschall
Copy link
Member

@marschall marschall commented Jul 21, 2019 •
edited by keilw

Add support for searching by numeric currency code to
ConfigurableCurrencyUnitProvider.

Extend the current register* and remove* methods to handle a numeric
currency code if present.

This fixes #308

This change is Reviewable

@marschall
Copy link
Member Author

I extended the existing register* and remove* methods rather than adding new ones. I believe it would be better to have only on of each but that would be an interface change.

@marschall marschall mentioned this pull request Jul 22, 2019
Closed
@acelopezco acelopezco mentioned this pull request Jul 24, 2019
Merged
@marschall
CCUP search by numeric currency code
af52f70 
Add support for searching by numeric currency code to
ConfigurableCurrencyUnitProvider.

Extend the current register* and remove* methods to handle a numeric
currency code if present.

This fixes JavaMoney#308
@keilw keilw merged commit 625e880 into JavaMoney:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stokito stokito stokito requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigurableCurrencyUnitProvider does not support searching by numeric code
3 participants
@marschall @stokito @keilw