Threads patch

[PhoenixInvertigo]

Breaking changes:

• When a server is present in a MessageCreateEvent, event.getServerTextChannel().get() is not safe anymore to be called since the channel can also be a thread now event.getServerThreadChannel().
• ServerChannel does not have a position anymore. Therefore the method to get the position and update it have been moved to PositionableServerChannel which extends the ServerChannel to integrate the ServerThreadChannel into this hierachy.

[ShindouMihou]

For immediate return methods, please follow codestyle:

public Class someReturnMethod() {
     return someReturnValue;
}

Instead of:

public Class someReturnMethod() { return someReturnValue; }

Also, the other comments I left. Other than that, I'll leave it to the others.

[felldo]

There are some changes for thread permissions which have to be considered discord/discord-api-docs@a674ee9

[PhoenixInvertigo]

I'll put it on my to-do list. Gonna try and get some more of this tested and implemented this weekend.

[felldo]

@PhoenixInvertigo please allow pushs to your branch

[PhoenixInvertigo]

@PhoenixInvertigo please allow pushs to your branch

I sent you a collab invite. If that's not what you were talking about, please let me know where to find that option

[felldo]

My rework is not finished but I don't have that much time currently to further work on it.
It would be greatly appreciated if someone else can continue to work on it. From what I saw that needs to be done:

• Don't let the ServerThreadChannel extends the ServerTextChannel as they are not really related
• Move the "position" methods from the ServerChannel interface to somewhere else as ServerThreadChannels do not have a position
• Implement the REST endpoints

[felldo]

@PhoenixInvertigo on the right side of this PR there's a checkbox "Allow edits...." is this activated? If not please do so.

[PhoenixInvertigo]

@KILLEliteMaste It's checked

[Saladoc]

Overall, it looks good. I've spotted some documentation inconsistencies that should be fixed, and included some other suggestions as well that you may or may not include.

[felldo]

@PhoenixInvertigo next time please don't take actions (applying the commits and changing the branch state) by yourself if you are not the current developer. This can lead to unnecessary more work which can be avoided.

[Saladoc]

lgtm, please clean up the history though before merging

[PhoenixInvertigo]

Sorry! Won't do it again

[felldo]

@PhoenixInvertigo if you plan to contribute more in the future to Javacord, please consider deleting your Javacord repository and refork it from the Javacord repo instead of a fork, as there seems to be an issue with pusing commits to your branches if it wasn't forked from the original repo.

Thanks for helping to implement this :)

[PhoenixInvertigo]

Makes sense! Thanks everyone for the work y'all did. ^_^