Tidy up RFF and extra tests/formatting #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on potential worry from @frazane, I have changed the unit tests to be for a 2d dataset with ARD (i.e. different lengthscales).
I also fixed a small bug that was added when changing the backend (@thomaspinder ;)) which meant that we never controlled the seed that set the random fourier features. Previously, I was using a
.init_paramsbut this wasn't updated properly.While I was at it, I also tidied my code slightly to reuse RFF functionality between the prior and posterior samplers.
There was a bit of extra formatting fixing that went on as well. Not sure why???