Remove unnecessary regexes #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8 Regexes removed that were caught with the generic regex
7 Regexes remove that are now caught with the
github\.com\/regex.This could lead to less coverage in some cases if user agents don't contain the generic catchall. For example I couldn't use the github regex to catch all CommaFeed useragents. But there is no way of knowing this without filling in more tests.
Every unique user agent we find should be put into tests to keep issues like this from happening. But we can't put every variation of bot user agent into the regex list as there would be thousands and slow this library down to a crawl. We have to strike a balance.