apu: Add VP debug output #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
commented
Feb 2, 2019
JayFoxRox
commented
Feb 20, 2019
| #endif | ||
|
|
||
| #if (PLAYBACK_VP_BINS_MASK > 0) || (DUMP_VP_BINS_MASK > 0) | ||
| void initialize_audio_debugger(MCPXAPUState *d) |
There was a problem hiding this comment.
Style is <object>_<verb>; also init?
JayFoxRox
commented
Feb 20, 2019
JayFoxRox
commented
Feb 20, 2019
|
|
||
| #if DUMP_VP_BINS_MASK > 0 | ||
| MCPX_APU_DPRINTF("mcpx frame ping\n"); | ||
| for (int i = 0; i < NUM_MIXBINS; i++) { |
JayFoxRox
commented
Feb 20, 2019
| #if PLAYBACK_VP_BINS_MASK > 0 | ||
| /* Output will be S32 mono; mix this now */ | ||
| int32_t mixed[NUM_SAMPLES_PER_FRAME] = { 0 }; | ||
| for (int i = 0; i < NUM_MIXBINS; i++) { |
JayFoxRox
commented
Feb 20, 2019
| // AUD_set_active_out(d->vp_bins_out, 1); //FIXME: Why does this hang GTK UI? | ||
| #endif | ||
| #if DUMP_VP_BINS_MASK > 0 | ||
| for (unsigned int i = 0; i < NUM_MIXBINS; i++) { |
JayFoxRox
force-pushed
the
vp-debug
branch
2 times, most recently
from
535bc5c
to
4384bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds debug routing options for the VP audio output.
On hardware, the VP is hardwired to output to the GP in a fixed and known format. We already have a framework for calculating VP audio, we can just take this 32 channel audio and re-route it. Options are:
QEMU audio card (1x mono audio output)
This adds a QEMU Audio card for the MCPX APU, with an output for the VP.
In reality APU shouldn't be an audio-card as it has no physical audio outputs (it just does audio processing; output is done by ACI) - so this is only a debug interface.
As QEMU audio is fed to speakers in realtime, any gaps in the playback will cause audible gaps in the audio. Any buffer overrun will drop packets or add audio latency.
File-output (32x mono audio output)
This custom debug function exists, because the
wavcaptureQMP command only supports resampled mono or stereo output.However, for debugging we want to preserve the original data of all 32 channels, without audio gaps or resampling.
The file output provides this continuous raw audio data without gaps.
There's a script to convert the binary APU audio dumps to audible wav files.
TODO: