Allow user to toggle showing all categories when searching

[h-hyuuga]

This PR makes it possible for a user to specify whether or not library search should show all categories when "Show All Categories" is off (see #1312 which introduced this behavior)

 

[Jays2Kings]

this was my worry with the previous pr, I let it through because I rather users take a vote on which to do, because this is not the main flow of j2k I dont want to add it as an option

Personally I think the old behavior makes more sense but I'm not going to be the one to run the poll for best use case

[h-hyuuga]

Personally I think the old behavior makes more sense

By "old behavior" do you mean the behavior pre-#1312 or post-#1312?

because this is not the main flow of j2k I dont want to add it as an option

I kinda figured, making every behavior user configurable doesn't make for good code. This PR was half an attempt to start a conversation in a way other than "change bad, pls revert" (and half an attempt to avoiding needing to maintain a fork haha).

Force showing all categories in search when Show All Categories adds a lot of friction to the way I usually search, and when I wanted to actually search my entire library I had the option to temporarily turn on Show All Categories.

But there's a non-zero amount of people who think the post-#1312 behavior is more intuitive so idk.

[Jays2Kings]

Personally I think the old behavior makes more sense

By "old behavior" do you mean the behavior pre-#1312 or post-#1312?

I do mean pre, I expected a some people prefer to only see the results of a single category while searching but my laziness of asking around made me just merge the or and wait for ppl on discord (or here) to ask to revert it back.

because this is not the main flow of j2k I dont want to add it as an option

I kinda figured, making every behavior user configurable doesn't make for good code. This PR was half an attempt to start a conversation in a way other than "change bad, pls revert" (and half an attempt to avoiding needing to maintain a fork haha).

Force showing all categories in search when Show All Categories adds a lot of friction to the way I usually search, and when I wanted to actually search my entire library I had the option to temporarily turn on Show All Categories.

But there's a non-zero amount of people who think the post-#1312 behavior is more intuitive so idk.

I'd say ask about it in the j2k discord and poll users to make a decision. My laziness is still strong on this so I don't feel like asking on there myself 😅

Worst case s97 still has their fork so if it dies, it can still live out there (and as you mentioned you can turn on show all/ungroup the library)

[Saud-97]

As a middle ground we can revert to old behavior but hide this toggle in another action next to the Search "query" globally.

So there will be two options at the top:

Search (or include) all categories | Search "query" globally

Naming can be worked on but I think you get the idea.

Not sure how would this toggle work though, if it will be saved on app close or has to be done on every search. What do you think on this?

For me personally I would always want the search to include all library so I'm more inclined toward saving the toggle status.