Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggle to searchbar to force show all categories #1386

Merged
merged 6 commits into from
Aug 28, 2022
Merged

Add toggle to searchbar to force show all categories #1386

merged 6 commits into from
Aug 28, 2022

Conversation

h-hyuuga
Copy link

@h-hyuuga h-hyuuga commented Aug 22, 2022 •
edited
Loading

This PR reverts the behavior introduced by #1312, and adds a toggle to show all categories during library search.

Supercedes #1375, which itself superceded #1340

The toggle is only visible when:

  • A search is active
  • A library is grouped by categories
  • Show all categories is disabled

image

image

Tooltip on Long Press:

image

Jays2Kings
Jays2Kings reviewed Aug 22, 2022
View reviewed changes
Copy link
Owner

@Jays2Kings Jays2Kings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with this set up, I'm fine with this being saved in preferences, still as a icon still with the same text, flow etc. Only difference is that it uses the preference to decide the starting way to show categories

app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt Outdated Show resolved Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt Outdated Show resolved Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt Outdated Show resolved Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/base/MiniSearchView.kt Show resolved Hide resolved
@h-hyuuga h-hyuuga marked this pull request as draft August 22, 2022 20:58
@h-hyuuga
Copy link
Author

I think with this set up, I'm fine with this being saved in preferences, still as a icon still with the same text, flow etc. Only difference is that it uses the preference to decide the starting way to show categories

Resolved by 0fb0b25

@h-hyuuga
Prevent duplicate views when onCreateOptionsMenu called multiple time…
ada5448 
…s in a row

        Fixes an issue where going to recents while on Library Tab, then
        re-opening the app would add a duplicate toggle
@h-hyuuga h-hyuuga marked this pull request as ready for review August 22, 2022 21:09
@Jays2Kings Jays2Kings merged commit 871aa2b into Jays2Kings:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jays2Kings Jays2Kings Jays2Kings left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@h-hyuuga @Jays2Kings