Added drone circuit assets for Behavior Metrics

[UtkarshMishra04]

fix #132

[pariaspe]

Are of the circuit models duplicated of the ones in CustomRobots? Iris models seems the same too.
I'm not sure about the convenience of duplicating the models. If it is only changing worlds and launch files, they can be located in exercise folder.

[UtkarshMishra04]

@sergiopaniego Can you please participate in this conversation?

1. The Iris models are same but the world and launch files are circuit specific.
2. The assets should move to /opt/jderobot/

[jmplaza]

I would use the Iris models from JdeRobot/drones repo. The circuit files may be used from CustomRobots (as they are already there) and the launch files + world files in the DeepLearningStudio repo.... We are facing here the typical reuse problem. Let's avoid replicating files along different applications....

There are three repositories for specific "assets" and drivers in JdeRobot (not directly included or ready-to-use in general ROS packages): JdeRobot/drones, JdeRobot/IndustrialRobots and JdeRobot/CustomRobots. They should be usable from several different applications. Maybe unifying the installation directory to /opt/jderobot for all of them.

@pariaspe, this PR comes from a GSoC project that @UtkarshMishra04 is doing, which is related to DeepLearningStudio and BehaviorMetrics. It is not related to RoboticsAcademy. We use there drones and Formula1 cars.

What do you think?

[UtkarshMishra04]

Thanks for the comment @jmplaza
The launch and world files cannot be directly used for drones as I am using the PX4 launch file as the base code and drone positioning and circuits in the world files.
We need to move everything to /opt/jderobot/, that's the only concern!

[pariaspe]

Ok @jmplaza, then there isn't a "exercise" to locate the non-duplicated files, but they can be located in DL-Studio repo as you have suggested.

As far as I know, /opt/jderobot/ is a legacy from jderobot_assets. Is there any reason to keep using it?
Of course we can move the installation, but doing it several changes have to be done in RoboticsAcademy exercises.

Sorry @UtkarshMishra04, I do not understand this sentence:

The launch and world files cannot be directly used for drones as I am using the PX4 launch file as the base code and drone positioning and circuits in the world files.

Launch files are similar to mavros_px4_sitl.launch, just changing world and pose arguments.

Of course we can move everything to /opt/jderobot/, but I would really appreciate if we could discuss it and take the best solution.

[UtkarshMishra04]

Hi @jmplaza

So after a short discussion with @pariaspe, we concluded that we can put all the circuit models in the drone_assets/models/ directory and I can copy that directory directly to /opt/jderobot/.
And for the additional launch and world files, a different package should work. This package will do all the copying tasks.
Let me know your suggestion and @pariaspe, kindly review the PR once again.

[pariaspe]

I would suggest to change package name. jderobot_assets is an old and deprecated dependency

[pariaspe]

Optional: jderobot install can be ignored. If we decide to remove it, envvars should be modified to new location

[pariaspe]

package name

[pariaspe]

add drone_assets dependency

[jmplaza]

Perfect