refactor(core): Throw an error when the document is not initialized.

In case the document is accessed but not available we should throw ASAP an error to prevent non explicit errors. Fixes angular#50138
JeanMeche · May 4, 2023 · c4565fe · c4565fe
1 parent 2419c48
commit c4565fe
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/goldens/public-api/core/errors.md b/goldens/public-api/core/errors.md
@@ -69,6 +69,8 @@ export const enum RuntimeErrorCode {
     // (undocumented)
     INVALID_SKIP_HYDRATION_HOST = -504,
     // (undocumented)
+    MISSING_DOCUMENT = 210,
+    // (undocumented)
     MISSING_GENERATED_DEF = 906,
     // (undocumented)
     MISSING_HYDRATION_ANNOTATIONS = -505,

diff --git a/packages/core/src/errors.ts b/packages/core/src/errors.ts
@@ -41,6 +41,7 @@ export const enum RuntimeErrorCode {
   PROVIDER_IN_WRONG_CONTEXT = 207,
   MISSING_INJECTION_TOKEN = 208,
   INVALID_MULTI_PROVIDER = -209,
+  MISSING_DOCUMENT = 210,
 
   // Template Errors
   MULTIPLE_COMPONENTS_MATCH = -300,

diff --git a/packages/core/src/render3/interfaces/document.ts b/packages/core/src/render3/interfaces/document.ts
@@ -6,6 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+import { RuntimeError, RuntimeErrorCode } from "../../errors";
+
 /**
  * Most of the use of `document` in Angular is from within the DI system so it is possible to simply
  * inject the `DOCUMENT` token and are done.
@@ -47,6 +49,11 @@ export function getDocument(): Document {
   } else if (typeof document !== 'undefined') {
     return document;
   }
+
+  if(typeof ngDevMode === 'undefined' || ngDevMode && !getDocument()) {
+    throw new RuntimeError(RuntimeErrorCode.MISSING_DOCUMENT, `The document is not available in this context. Make sure the DOCUMENT injection token is provided.`)
+  }
+
   // No "document" can be found. This should only happen if we are running ivy outside Angular and
   // the current platform is not a browser. Since this is not a supported scenario at the moment
   // this should not happen in Angular apps.