Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore lib & dist when there's a viable solution for Bower & GitHub downloads #173

Closed
dcousens opened this issue May 7, 2015 · 6 comments
Assignees

Comments

@dcousens
Copy link
Collaborator

dcousens commented May 7, 2015

I understand the reason for why there is a src and a lib, but that doesn't change the fact it is confusing, and there is nothing alluding to what the contribution or build process is.

@JedWatson could you please shed some light on this?

If the lib/ folder is just a reactify'd version of the src folder for distribution, then just make it part of your dist/ folder?

@dcousens
Copy link
Collaborator Author

dcousens commented May 7, 2015

To be honest, there is so little JSX, is there any other reason for this?

@dcousens dcousens added this to the 0.4.9 milestone May 7, 2015
@dcousens dcousens changed the title src / lib Double up src / lib double up May 7, 2015
@dcousens
Copy link
Collaborator Author

dcousens commented May 7, 2015

The typical pre-publish solution can be found here. But that does suck if you want to use the lib directly from GitHub.

@dcousens dcousens added question and removed feature labels May 7, 2015
dcousens added a commit that referenced this issue May 7, 2015
Adds some clarity to #173
piecyk pushed a commit to piecyk/react-select that referenced this issue May 8, 2015
@xcatliu
Copy link

xcatliu commented May 15, 2015

By the way, what is the build process for lib?

StefanBilliet pushed a commit to StefanBilliet/react-select that referenced this issue May 18, 2015
@dcousens
Copy link
Collaborator Author

@JedWatson is this still meant to be the case? Or were we going to put lib/ in .npmignore?

bruderstein added a commit to bruderstein/react-select that referenced this issue Aug 6, 2015
Currently issue JedWatson#173 (brianmcd/contextify#173) of contextify is causing all PRs to fail on io.js.
Until this issue is resolved, I'd recommend pinning the io.js version to v2.5.0 (the last in the 2.x line), such that we get accurate status from travis.

This can be reverted when the issue with contextify is resolved.
@dcousens
Copy link
Collaborator Author

This doesn't look like its going to change.
ping @JedWatson close?

@JedWatson
Copy link
Owner

We've gone with an "ignore lib" solution for elemental and Bower builds are lagging behind 😞

I'm a big fan of not doubling up on code in repos but until there's a workable solution here that doesn't break existing usage, this is where we are.

Planning to port whatever we figure out for Elemental when it lands.

In the meantime to answer an earlier question:

To be honest, there is so little JSX, is there any other reason for this?

Because babel ✨

@JedWatson JedWatson removed this from the 0.5.1 milestone Sep 30, 2015
@JedWatson JedWatson changed the title src / lib double up Ignore lib & dist when there's a viable solution for Bower & GitHub downloads Sep 30, 2015
@JedWatson JedWatson added todo and removed question labels Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants