-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore lib & dist when there's a viable solution for Bower & GitHub downloads #173
Comments
To be honest, there is so little JSX, is there any other reason for this? |
The typical pre-publish solution can be found here. But that does suck if you want to use the lib directly from GitHub. |
Adds some clarity to JedWatson#173
By the way, what is the build process for |
Adds some clarity to JedWatson#173
@JedWatson is this still meant to be the case? Or were we going to put |
Currently issue JedWatson#173 (brianmcd/contextify#173) of contextify is causing all PRs to fail on io.js. Until this issue is resolved, I'd recommend pinning the io.js version to v2.5.0 (the last in the 2.x line), such that we get accurate status from travis. This can be reverted when the issue with contextify is resolved.
This doesn't look like its going to change. |
We've gone with an "ignore lib" solution for elemental and Bower builds are lagging behind 😞 I'm a big fan of not doubling up on code in repos but until there's a workable solution here that doesn't break existing usage, this is where we are. Planning to port whatever we figure out for Elemental when it lands. In the meantime to answer an earlier question:
Because babel ✨ |
I understand the reason for why there is a
src
and alib
, but that doesn't change the fact it is confusing, and there is nothing alluding to what the contribution or build process is.@JedWatson could you please shed some light on this?
If the
lib/
folder is just areactify
'd version of thesrc
folder for distribution, then just make it part of yourdist/
folder?The text was updated successfully, but these errors were encountered: