Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document breaking change of removing getInputValue #2195

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

turadg
Copy link
Contributor

@turadg turadg commented Dec 4, 2017

Our app on rc10 broke when we went to the release.


This change is Reviewable

Our app on rc10 broke when we went to the release.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.431% when pulling 100de59 on turadg:patch-1 into 75f3043 on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for that @turadg - sorry I missed it in the release notes.

Out of curiosity - it was removed in #2108 because it appears to be unused. What was your use-case for it?

@JedWatson JedWatson merged commit 04317f9 into JedWatson:master Dec 5, 2017
@turadg
Copy link
Contributor Author

turadg commented Dec 5, 2017

We have a Select component that wraps react-select. Looking at its history, we built it on a fork of react-select. In Oct 2016 we switched back to npm distro of react-select on 1.0.0-rc.2. Our handleInputKeyUp went from getting the input value from the DOM to getting it by getInputValue.

@turadg turadg deleted the patch-1 branch December 5, 2017 17:38
@JedWatson
Copy link
Owner

Thanks for the reply @turadg. Is your use case now covered by the handleInputKeyUp event?

@turadg
Copy link
Contributor Author

turadg commented Dec 5, 2017

That's our handler for onKeyUp event. To get it working again I just replaced .getInputValue() with .state.inputValue. So all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants