Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing getInputValue function #2108

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Conversation

uxtx
Copy link
Contributor

@uxtx uxtx commented Oct 28, 2017

Was doing some cleanup and testing work to try to bump up the coverage and ran across this unused getInputValue function - don't see it called anywhere, react-select seems to compile and tests run perfectly without it - looks like it was part of the initial work for allowCreate (7fe723f) , but it seems unused now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 92.932% when pulling 82722fb on uxtx:unused-input-value into de7aa68 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 92.782% when pulling 82722fb on uxtx:unused-input-value into de7aa68 on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for this @uxtx, much appreciated!

@JedWatson JedWatson merged commit b83e3e7 into JedWatson:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants