[v2] Pressing <Enter> in IME mode should not select a option #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamabe
changed the title
gwyneplaine
approved these changes
Jul 4, 2018
There was a problem hiding this comment.
@shamabe this looks good to me, but wanted to get @JedWatson eyes on this, this seems like core behaviour and makes sense to include in the base select. However perhaps you'd like this in a wrapping component instead? Would be good to get your thoughts on this Jed.
|
This looks great @shamabe, thanks! |
|
Hey shamabe, user maplesyrupsucker tipped you 2500 bits in Bitcoin Cash ( ~ $1.8125 ). You can also add the "thumbs down" reaction to maplesyrupsucker's comment above to prevent future tips. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In composing mode, enter key is for selecting a suggest of conversion.
So that, the behavior of enter key is collision in "react-select" with IME.
Like this...
It is necessary to check whether it is in composing-mode or not.
Following is the preferred behavior.