Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type for CreateOptionActionMeta option field #4756

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

fdcds
Copy link
Contributor

@fdcds fdcds commented Sep 7, 2021

Creatable sends an option in its create-action meta data (cf.

const newActionMeta = {
action: 'create-option',
name,
option: newOptionData,
};
), but the type does not expose it.

Closes: #4755

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2021

🦋 Changeset detected

Latest commit: f2201c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f2201c1:

Sandbox Source
react-codesandboxer-example Configuration

@Methuselah96
Copy link
Collaborator

Thanks! Can you add a changeset?

@fdcds
Copy link
Contributor Author

fdcds commented Sep 7, 2021

Thanks! Can you add a changeset?

I tried my best in ca2c0e5. Please revise if necessary.

Copy link
Collaborator

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Methuselah96 Methuselah96 added this to the 5.0 milestone Sep 7, 2021
@JedWatson JedWatson merged commit b46e801 into JedWatson:master Sep 16, 2021
This was referenced Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action.option field missing in type for create-action meta data
3 participants