Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at documenter #71

Merged
merged 7 commits into from
Aug 14, 2020
Merged

Attempt at documenter #71

merged 7 commits into from
Aug 14, 2020

Conversation

JeffFessler
Copy link
Owner

@johnnychen94 I have run julia make.jl locally to try to generate html documentation and it runs locally but you put /docs/build into .gitignore so it doesn't end up on github. In the process I found many docstrings that needed fixing so this PR is mostly about that, but it would be nice now to see if we can get this very limited initial documentation working online.

@JeffFessler JeffFessler marked this pull request as draft August 14, 2020 15:49
# "Examples" => examples,
"Function References" => "reference.md",
]
)

# examples_cb()

deploydocs(repo = "github.com/JeffFessler/MIRT.jl")
deploydocs(repo = "github.com/JeffFessler/MIRT.jl")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run julia make.jl locally to try to generate html documentation and it runs locally but you put /docs/build into .gitignore so it doesn't end up on github.

This is a no-op when we run it locally, and will push to gh-pages branch if it's running on a CI environment, e.g., Github Actions. See also: https://juliadocs.github.io/Documenter.jl/dev/man/hosting/#.gitignore

I'm really sorry that I haven't found some time to add the demos here, I was way too exhausted these days in a day-to-day seminar. My limited time for Julia is spent on setting up storage mirror servers, e.g., SJTUG and BFSU so that users in China can add packages without much trouble; they are broken these days and I spent a lot of time on debugging and enhancing the tool.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          49       49           
  Lines        2113     2113           
=======================================
  Hits         2108     2108           
  Misses          5        5           
Impacted Files Coverage Δ
src/algorithm/general/ncg.jl 100.00% <ø> (ø)
src/algorithm/general/ogm_ls.jl 100.00% <ø> (ø)
src/fbp/cuboid_im.jl 100.00% <ø> (ø)
src/fbp/ellipse_sino.jl 100.00% <ø> (ø)
src/fbp/rect_im.jl 100.00% <ø> (ø)
src/fbp/rect_sino.jl 100.00% <ø> (ø)
src/fbp/sino_geom.jl 100.00% <ø> (ø)
src/io/shows.jl 100.00% <ø> (ø)
src/mri/kspace-spiral.jl 100.00% <ø> (ø)
src/mri/kspace.jl 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9352463...2ed5e99. Read the comment docs.

@JeffFessler JeffFessler marked this pull request as ready for review August 14, 2020 19:44
@JeffFessler
Copy link
Owner Author

Well, I'm going to merge this now and hope that it triggers a real doc build...

@JeffFessler JeffFessler merged commit e7b2635 into master Aug 14, 2020
@JeffFessler JeffFessler deleted the doc1 branch August 14, 2020 19:47
@JeffFessler
Copy link
Owner Author

@johnnychen94 ok, i see some stuff in the gh-pages branch now, and i configured the settings for MIRT.jl to enable github pages and the settings says "your site is published at" https://jefffessler.github.io/MIRT.jl/ but i'm not seeing anything there. Maybe I need to try another push to trigger it now that I have the github.io set up.

@johnnychen94
Copy link
Contributor

johnnychen94 commented Aug 15, 2020

It's https://jefffessler.github.io/MIRT.jl/dev/ for dev docs and https://jefffessler.github.io/MIRT.jl/stable for versioned docs (not yet existed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants