Fix typo #1
Merged
Fix typo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! You should check out the work done by @caffeinatedMike: https://github.com/caffeinatedMike/python-androidtv and https://github.com/caffeinatedMike/androidtv. I don't actually own an Android TV device, so my contribution was just based off the Fire TV component. |
JeffLIrion
added a commit
that referenced
this pull request
Feb 18, 2022
* Add Option for Custom Audio State command * Add Option for Custom Audio State command * Add Option for Custom Audio State command * Add Option for Custom Audio State command * Add Option for Custom Audio State command Correction to default return value * Formatting * Formatting * Formatting Fix * Add test for CUSTOM_AUDIO_STATE * Test correction * PR Suggestions (#1) * Reorder _cmd function * Code suggestion change * Code suggestion change * Re-Ordering * Update docs to refer to function * Update basetv.py Co-authored-by: Jeff Irion <JeffLIrion@users.noreply.github.com>
grimpy
added a commit
to grimpy/python-androidtv
that referenced
this pull request
Oct 12, 2022
Parsing of current app is broken incase google assitant gets triggered and closed again. Suddenly we have Windows JeffLIrion#1 as `mOwnerUid=10050 showForAllUsers=false package=com.google.android.inputmethod.latin appop=NONE` this is not correct. In this pull request based on the link issue, I've moved the command to find the windows that has the inputfocus instead See: home-assistant/core#69723
grimpy
added a commit
to grimpy/python-androidtv
that referenced
this pull request
Oct 13, 2022
Parsing of current app is broken incase google assitant gets triggered and closed again. Suddenly we have Windows JeffLIrion#1 as `mOwnerUid=10050 showForAllUsers=false package=com.google.android.inputmethod.latin appop=NONE` this is not correct. In this pull request based on the link issue, I've moved the command to find the windows that has the inputfocus instead See: home-assistant/core#69723 Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com>
JeffLIrion
pushed a commit
that referenced
this pull request
Oct 13, 2022
Parsing of current app is broken incase google assitant gets triggered and closed again. Suddenly we have Windows #1 as `mOwnerUid=10050 showForAllUsers=false package=com.google.android.inputmethod.latin appop=NONE` this is not correct. In this pull request based on the link issue, I've moved the command to find the windows that has the inputfocus instead See: home-assistant/core#69723 Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com> Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I only now am checking all your work, from the pipy package to your fixes in python-adb, this is an amazing piece of work, thank you so much you're awesome!