From Ed Brash: SCons fixes for interactive interpreter segfaults

There are three changes, only one of which probably relates to the
segfault issue:

- Update the ROOT library definition in SConstruct to
  "root-config --glibs" to match Makefile definition.
- Set the -DNDEBUG and -DWITH_DEBUG command line flags
  consistent with Makefile.
- Add -fPIC to g++ command line flags specifically for the
  compilation of src/main.C ... this was not done before, and
  appears to have been the source of the segfault issue.

Closes #141

SConstruct

@@ -57,7 +57,7 @@ except KeyError:
         pass    # ROOTSYS not defined
 
 try:
-        baseenv.ParseConfig('$ROOTCONFIG --cflags --libs')
+        baseenv.ParseConfig('$ROOTCONFIG --cflags --glibs')
         if sys.version_info >= (2, 7):
                 cmd = baseenv['ROOTCONFIG'] + " --cxx"
                 baseenv.Replace(CXX = subprocess.check_output(cmd, shell=True).rstrip())

SDK/SConstruct

@@ -58,7 +58,7 @@ except KeyError:
         pass    # ROOTSYS not defined
 
 try:
-        baseenv.ParseConfig('$ROOTCONFIG --cflags --libs')
+        baseenv.ParseConfig('$ROOTCONFIG --cflags --glibs')
         if sys.version_info >= (2, 7):
                 cmd = baseenv['ROOTCONFIG'] + " --cxx"
                 baseenv.Replace(CXX = subprocess.check_output(cmd, shell=True).rstrip())

SDK/site_scons/darwin64.py

@@ -11,11 +11,12 @@ def config(env,args):
 
         if int(debug):
                 env.Append(CXXFLAGS = env.Split('-g -O0'))
-                env.Append(CPPDEFINES= 'WITH_DEBUG')
         else:
                 env.Append(CXXFLAGS = '-O')
                 env.Append(CPPDEFINES= 'NDEBUG')
 
+        env.Append(CPPDEFINES= 'WITH_DEBUG')
+
         if int(standalone):
                 env.Append(STANDALONE= '1')
 
@@ -28,7 +29,7 @@ def config(env,args):
         if int(srcdist):
                 env.Append(SRCDIST= '1')
 
-        env.Append(CXXFLAGS = env.Split('-Wall'))
+        env.Append(CXXFLAGS = env.Split('-Wall -fPIC'))
         env.Append(CPPDEFINES = 'MACVERS')
 
         cxxversion = env.subst('$CXXVERSION')

SDK/site_scons/linux32.py

@@ -11,12 +11,13 @@ def config(env,args):
 
         if int(debug):
                 env.Append(CXXFLAGS = env.Split('-g -O0'))
-                env.Append(CPPDEFINES= 'WITH_DEBUG')
         else:
                 env.Append(CXXFLAGS = '-O')
                 env.Append(CPPDEFINES= 'NDEBUG')
 
-        if int(standalone):
+        env.Append(CPPDEFINES= 'WITH_DEBUG')
+
+	if int(standalone):
                 env.Append(STANDALONE= '1')
 
         if int(cppcheck):
@@ -28,7 +29,7 @@ def config(env,args):
         if int(srcdist):
                 env.Append(SRCDIST= '1')
 
-        env.Append(CXXFLAGS = env.Split('-m32 -Wall'))
+        env.Append(CXXFLAGS = env.Split('-m32 -Wall -fPIC'))
         env.Append(CPPDEFINES = 'LINUXVERS')
 
         cxxversion = env.subst('$CXXVERSION')

SDK/site_scons/linux64.py

@@ -11,11 +11,12 @@ def config(env,args):
 
         if int(debug):
                 env.Append(CXXFLAGS = env.Split('-g -O0'))
-                env.Append(CPPDEFINES= 'WITH_DEBUG')
         else:
                 env.Append(CXXFLAGS = '-O')
                 env.Append(CPPDEFINES= 'NDEBUG')
 
+        env.Append(CPPDEFINES= 'WITH_DEBUG')
+
         if int(standalone):
                 env.Append(STANDALONE= '1')
 
@@ -28,7 +29,7 @@ def config(env,args):
         if int(srcdist):
                 env.Append(SRCDIST= '1')
 
-        env.Append(CXXFLAGS = env.Split('-Wall'))
+        env.Append(CXXFLAGS = env.Split('-Wall -fPIC'))
         env.Append(CPPDEFINES = 'LINUXVERS')
 
         cxxversion = env.subst('$CXXVERSION')

site_scons/darwin64.py

@@ -11,11 +11,12 @@ def config(env,args):
 
         if int(debug):
                 env.Append(CXXFLAGS = env.Split('-g -O0'))
-                env.Append(CPPDEFINES= 'WITH_DEBUG')
         else:
                 env.Append(CXXFLAGS = '-O')
                 env.Append(CPPDEFINES= 'NDEBUG')
 
+        env.Append(CPPDEFINES= 'WITH_DEBUG')
+
         if int(standalone):
                 env.Append(STANDALONE= '1')
 
@@ -28,7 +29,7 @@ def config(env,args):
         if int(srcdist):
                 env.Append(SRCDIST= '1')
 
-        env.Append(CXXFLAGS = env.Split('-Wall'))
+        env.Append(CXXFLAGS = env.Split('-Wall -fPIC'))
         env.Append(CPPDEFINES = 'MACVERS')
 
         cxxversion = env.subst('$CXXVERSION')

site_scons/linux32.py

@@ -11,12 +11,13 @@ def config(env,args):
 
         if int(debug):
                 env.Append(CXXFLAGS = env.Split('-g -O0'))
-                env.Append(CPPDEFINES= 'WITH_DEBUG')
         else:
                 env.Append(CXXFLAGS = '-O')
                 env.Append(CPPDEFINES= 'NDEBUG')
 
-        if int(standalone):
+        env.Append(CPPDEFINES= 'WITH_DEBUG')
+
+	if int(standalone):
                 env.Append(STANDALONE= '1')
 
         if int(cppcheck):
@@ -28,7 +29,7 @@ def config(env,args):
         if int(srcdist):
                 env.Append(SRCDIST= '1')
 
-        env.Append(CXXFLAGS = env.Split('-m32 -Wall'))
+        env.Append(CXXFLAGS = env.Split('-m32 -Wall -fPIC'))
         env.Append(CPPDEFINES = 'LINUXVERS')
 
         cxxversion = env.subst('$CXXVERSION')

site_scons/linux64.py

@@ -11,11 +11,12 @@ def config(env,args):
 
         if int(debug):
                 env.Append(CXXFLAGS = env.Split('-g -O0'))
-                env.Append(CPPDEFINES= 'WITH_DEBUG')
         else:
                 env.Append(CXXFLAGS = '-O')
                 env.Append(CPPDEFINES= 'NDEBUG')
 
+        env.Append(CPPDEFINES= 'WITH_DEBUG')
+
         if int(standalone):
                 env.Append(STANDALONE= '1')
 
@@ -28,7 +29,7 @@ def config(env,args):
         if int(srcdist):
                 env.Append(SRCDIST= '1')
 
-        env.Append(CXXFLAGS = env.Split('-Wall'))
+        env.Append(CXXFLAGS = env.Split('-Wall -fPIC'))
         env.Append(CPPDEFINES = 'LINUXVERS')
 
         cxxversion = env.subst('$CXXVERSION')