-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: tool migration to Chibi-scheme #6
Conversation
- Externs created and fully tested - Clean structure - Prepare for wrappers but still TODO
src_chibi/ksyscalls.scm
Outdated
|
||
(define (default_syscall_ret-wrapper wrapper) | ||
(joined displayed | ||
`( "\tcase" ,(hash-table-ref wrapper 'id) ":" ,nl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use (indent N)
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added some support for elegant indentation not based on tabs and fixed to 4 spaces.
- Have to make it coherent in the whole file
- Still not really sure about the use of
joined displayed
pair all the time. There should be a simpler way to solve it. - Thinking about making a macro/function that creates simple codeblocks line by line from a list of lines to avoid having to use
indent
andnl
so much. Just send lines in a list and let the func join everything together.
- Replace `joined displayed` with `each` which fits better the job sometimes - Add some extra templates - Replace `case` with `cond` in the broken cases
First working version of Please @Shamar take a look to this. |
Looks fine to me. As for indentation, C code in Jehanne is indented with tabs (as in Plan 9). Feel free to indent scheme as you like, but I'd prefer to have all C code we are responsible for that follows the same conventions. Also, please wait before attacking |
UGH TABS ;) Anyway I prepared the code to be able to work on that easily. |
Hi @ekaitz-zarraga I finally moved Jehanne out of GitHub. I close this issue, as I've also replaced Go with rc scripts. Thanks for your help and support! |
Migration of all the tools to chibi scheme.
Pull request for discussion and development