Improvement: Made compiling more secure and silent.

CHANGELOG.md

@@ -23,6 +23,9 @@ been moved an renamed.
     also doesn't take a plt argument anymore. The plt module is now imported
     when a `MatplotlibFigure` figure is instantiated.
 
+- Compiling is more secure now and it doesn't show output unless an error occurs
+    or explicitly specified.
+
 ### Added
 - Lots of documentation!!!!!
 - A float environment base class.

pylatex/document.py

@@ -94,15 +94,18 @@ def dumps(self):
     def generate_tex(self, filepath=''):
         super().generate_tex(self.select_filepath(filepath))
 
-    def generate_pdf(self, filepath='', clean=True, compiler='pdflatex'):
+    def generate_pdf(self, filepath='', clean=True, compiler='pdflatex',
+                     silent=True):
         """Generate a pdf file from the document.
 
         :param filepath: the name of the file
         :param clean: whether non-pdf files created by `pdflatex` must be
             removed or not
+        :param silent: whether to hide compiler output
 
         :type filepath: str
         :type clean: bool
+        :type silent: bool
         """
 
         filepath = self.select_filepath(filepath)
@@ -115,10 +118,17 @@ def generate_pdf(self, filepath='', clean=True, compiler='pdflatex'):
 
         self.generate_tex(basename)
 
-        command = compiler + ' --interaction=nonstopmode --jobname="' + \
-            basename + '" "' + basename + '.tex"'
+        command = [compiler, '--interaction', 'nonstopmode',
+                   '--jobname', basename, basename + '.tex']
 
-        subprocess.check_call(command, shell=True)
+        try:
+            output = subprocess.check_output(command)
+        except subprocess.CalledProcessError as e:
+            print(e.output.decode())
+            raise e
+        else:
+            if not silent:
+                print(output.decode())
 
         if clean:
             for ext in ['aux', 'log', 'out', 'tex']: