Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

Handle interrupts cleanly and remove "exit message" #24

Open
JensRantil opened this issue Aug 21, 2012 · 1 comment
Open

Handle interrupts cleanly and remove "exit message" #24

JensRantil opened this issue Aug 21, 2012 · 1 comment
Labels
enhancement
Milestone
v. 0.2

Comments

@JensRantil
Copy link
Owner

Currently, Rewind does not shut down cleanly on interrupts and CTRL+C. This needs to be fixed. See http://zguide.zeromq.org/py:interrupt for details.

This issue should also remove the "exit message" feature and have tests shutting down the loop by calling the signal-handler instead to exit the message loop. This will make test coverage of exit handling greater.
JensRantil added a commit that referenced this issue Aug 29, 2012
@JensRantil
Bugfix: Exit message not needed to start
28a0de7 
Since a test instances of Rewind cannot currently be shut down correctly
without an exit message, testing this scenario is hard. Issue #24 intend
to solve this is nicer way.

This commit fixes issue #28 and will be published to pip immediately.
JensRantil added a commit that referenced this issue Sep 1, 2012
@JensRantil
Use in-process quitter socket instead of exit msg
64497b1 
This solves issue #24.

Details:
 * Renamed `_RewindRunner` to `_MessagePasser`. It says more about what
   the class actually do.
 * Changed to use module-specific loggers instead of the global root
   logger.
@JensRantil JensRantil mentioned this issue Sep 1, 2012
Open
@JensRantil
Copy link
Owner Author

See http://zguide.zeromq.org/py:interrupt

JensRantil added a commit that referenced this issue Nov 15, 2012
@JensRantil
Use in-process quitter socket instead of exit msg
3b4ca7b 
This solves issue #24.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v. 0.2
Development

No branches or pull requests
1 participant
@JensRantil