Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Implementing focus on index.html #20

Open
5 of 6 tasks
JeremieLitzler opened this issue Mar 7, 2018 · 0 comments
Open
5 of 6 tasks

Implementing focus on index.html #20

JeremieLitzler opened this issue Mar 7, 2018 · 0 comments

Comments

@JeremieLitzler
Copy link
Owner

JeremieLitzler commented Mar 7, 2018

What to improve?

  • The map has a lot of buttons. It requires a lot of TAB presses to get to the search button!
  • The search button needs to be above the map.
  • When clicking search with the key ENTER, the focus is still behind the modal.
  • When viewing the filters modal, the focus exists the modal after focusing on the close button.

Checklist

  • Make the map easier to navigate through with a keyboard
  • Add a skip link to go straight to the search button.
  • Make sure the focus is on the first select element in the filter modal.
  • Make sure the focus stays in the filters modal while it is opened.
  • Make sure the focus returns to the search button when the user clicks the close button in the filters modal.
  • make sure the focus returns to the search button after selecting a dropdown item.
WebDevJL pushed a commit that referenced this issue Mar 8, 2018
- update the modal component to work properly
- add skip-link to go to search

Cover: #20, #21, #24
WebDevJL pushed a commit that referenced this issue Mar 9, 2018
- all the modals meets the requirements of #24
- the code is reusable
 covers : #24, #20 and #21
WebDevJL pushed a commit that referenced this issue Mar 13, 2018
- implements the responsive images on the details page
- update the image url construction to be used everywhere
- enable keyboard pseudo-scrolling on reviews using links
- update the headings to be semantically correct

- improve search modal to be able to select several options

Covers: #24, #18, #20, #21 and #19
WebDevJL pushed a commit that referenced this issue Mar 14, 2018
- All non-text contents provide text alternatives
- Elements on the page use the appropriate semantic elements. For those elements in which a semantic element is not available, appropriate ARIA roles are defined.
- Headings are used properly
- Links have a href and title attributes.
- Make sure all buttons text are descriptives enough (ex: Learn More or More isn't enough).
- Semantic elements (header, nav, main, section, article, footer, ...) are used properly
- Fix the focus on a long list of reviews

Covers: #28, #19, #20, #21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant