Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning for release of v5.3.2 #7825

Closed
Jermolene opened this issue Oct 31, 2023 · 21 comments
Closed

Planning for release of v5.3.2 #7825

Jermolene opened this issue Oct 31, 2023 · 21 comments

Comments

@CrossEye
Copy link
Contributor

CrossEye commented Nov 1, 2023

I don't know if #7729 is ready from your perspective. It feels complete to me. If so, I hope it's up for consideration.

@rmunn
Copy link
Contributor

rmunn commented Nov 1, 2023

I want to get #7694 in. It's been ready for a while, just need to work out the best way to add a $list-join widget to parallel the $list-template widget. Which means getting #7804 fixed. (I think fixing #7804 before release is really important, otherwise the current surprising behavior will become locked in by backwards-compatibility policies, and I don't think that's what we want.)

@pmario
Copy link
Contributor

pmario commented Nov 1, 2023

@pmario
Copy link
Contributor

pmario commented Nov 1, 2023

@pmario
Copy link
Contributor

pmario commented Nov 1, 2023

@rmunn
Copy link
Contributor

rmunn commented Nov 3, 2023

@rmunn
Copy link
Contributor

rmunn commented Nov 7, 2023

Doing extensive tests on #7694, and found a weird corner-case bug as well as a simpler reproduction for it (though that might be a different bug). No more merge conflicts on #7694, but I need to nail down those bugs before I feel confident in merging it. If #7694 misses the merge window for 5.3.2, oh well, it can go into 5.3.3. I really want to get it into 5.3.2, though, so I'll keep you updated on my progress nailing down those last couple of bugs.

@rmunn
Copy link
Contributor

rmunn commented Nov 7, 2023

@Jermolene
Copy link
Owner Author

Thanks @CrossEye @rmunn @pmario I've updated the OP with the tickets you've mentioned.

@rmunn
Copy link
Contributor

rmunn commented Nov 14, 2023

(To clarify, #7694 used to contain that bugfix, but I pulled it out into its own PR as per @Jermolene's request in #7694 (comment))

@Jermolene
Copy link
Owner Author

I've updated the roadmap in the OP to push the release out by 2 weeks. The reason is that I have been working on #7837 and would like to try to get a fix into the next release.

@rmunn
Copy link
Contributor

rmunn commented Nov 16, 2023

Then maybe I'll work on PRs for #7839 and #7840 (negative indexes, and adding jsoninsert, jsonremove, jsonpush, and jsonpop operators). They should be straightforward; with a couple extra weeks to work with I should be able to get them done before the new PR freeze date.

@Jermolene
Copy link
Owner Author

I've updated the roadmap in the OP to push the release out by 2 weeks. The reason is that I have been working on #7837 and would like to try to get a fix into the next release.

The draft PR is at #7843

Then maybe I'll work on PRs for #7839 and #7840 (negative indexes, and adding jsoninsert, jsonremove, jsonpush, and jsonpop operators). They should be straightforward; with a couple extra weeks to work with I should be able to get them done before the new PR freeze date.

Great, thanks @rmunn

@rmunn
Copy link
Contributor

rmunn commented Nov 21, 2023

#7849 is a PR for #7839 (allowing negative indexes in JSON operators). I'll defer implementing #7840 until the 5.3.3 release cycle, so that there's time to have a conversation about the best set of operators to implement.

@Jermolene
Copy link
Owner Author

I've created the usual ticket to track PRs that have been deferred from this release: #7856

@pmario
Copy link
Contributor

pmario commented Nov 28, 2023

@Jermolene ... It seems the current timeline "stands". right? -- I would like to create a post at Talk, to let the users know, that they should start extensive testing of the prerelease version. I'll pin the post till 8th. Dec 23

@Jermolene
Copy link
Owner Author

@Jermolene ... It seems the current timeline "stands". right? -- I would like to create a post at Talk, to let the users know, that they should start extensive testing of the prerelease version. I'll pin the post till 8th. Dec 23

Yes, the freeze is now in place, albeit @saqimtiaz and I plan to continue work on #7734 for a few days because it doesn't affect the core itself.

I plan to make an announcement on Talk shortly.

@pmario
Copy link
Contributor

pmario commented Nov 28, 2023

I plan to make an announcement on Talk shortly.

We also need a new banner

@Jermolene
Copy link
Owner Author

Yes, the freeze is now in place, albeit @saqimtiaz and I plan to continue work on #7734 for a few days because it doesn't affect the core itself.

We've decided to defer the improvements to the Tour plugin until the next release. There are no other PRs planned for merging but we will continue to accept translation updates (and docs updates, as always).

@Jermolene
Copy link
Owner Author

Closing this now that v5.3.2 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants