Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core macros don't allow pragmas in action strings #7855

Merged
merged 3 commits into from Nov 24, 2023
Merged

Core macros don't allow pragmas in action strings #7855

merged 3 commits into from Nov 24, 2023

Conversation

Jermolene
Copy link
Owner

As reported by @CodaCodr over at talk.tiddlywiki.org, the core "tag-picker" macro does not permit pragmas within the "actions" parameter:

\procedure tag-actions()
  \procedure update()
    <!--  do things -->
  \end update
<<update>>
\end tag-actions

<$transclude $variable=tag-picker tagField="my-tags" actions=<<tag-actions>> />

The result is garbled:

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Nov 24, 2023 10:49am

@Jermolene Jermolene mentioned this pull request Nov 23, 2023
Closed
@CodaCodr CodaCodr mentioned this pull request Nov 23, 2023
Closed
saqimtiaz
saqimtiaz reviewed Nov 24, 2023
View reviewed changes
core/wiki/macros/tag-picker.tid Outdated
@@ -16,7 +16,7 @@ second-search-filter: [tags[]is[system]search:title<userInput>sort[]]
emptyMessage="<$action-listops $tiddler=<<saveTiddler>> $field=<<__tagField__>> $subfilter='-[<tag>]'/>"
>
<$action-listops $tiddler=<<saveTiddler>> $field=<<__tagField__>> $subfilter="[<tag>trim[]]"/>
$actions$
<$macrocall $name="__actions__"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we use the transclude widget: <$transclude $variable="__actions__"/>

@Jermolene Jermolene marked this pull request as ready for review November 24, 2023 10:38
@Jermolene Jermolene merged commit ca41a8d into master Nov 24, 2023
3 of 4 checks passed
munnox pushed a commit to munnox/TiddlyWiki5 that referenced this pull request Dec 24, 2023
@Jermolene @munnox
Core macros don't allow pragmas in action strings (Jermolene#7855)
dab9773 
* First commit

* Transclude preferred over macrocall
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqimtiaz saqimtiaz saqimtiaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jermolene @saqimtiaz