Avoid skipping extra whitespace in wikiparser.js #7835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When wikiparser parses text looking for a pragma block, it skips whitespace before looking for the next pragma. If no pragma is found, we should return the parse position to the original location so that the skipped whitespace can be parsed as a text node. This allows the attribute `join=" and "` to parse as " and " rather than "and ".
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Nov 14, 2023
|
Great, thanks @rmunn |
Jermolene
added a commit
that referenced
this pull request
Dec 17, 2023
This is intended to revert some of the behaviour introduced in #7835, see the discussion here: #7888 (comment)
This was referenced Dec 17, 2023
Jermolene
added a commit
that referenced
this pull request
Dec 21, 2023
This is intended to revert some of the behaviour introduced in #7835, see the discussion here: #7888 (comment)
munnox
pushed a commit
to munnox/TiddlyWiki5
that referenced
this pull request
Dec 24, 2023
When wikiparser parses text looking for a pragma block, it skips whitespace before looking for the next pragma. If no pragma is found, we should return the parse position to the original location so that the skipped whitespace can be parsed as a text node. This allows the attribute `join=" and "` to parse as " and " rather than "and ".
munnox
pushed a commit
to munnox/TiddlyWiki5
that referenced
this pull request
Dec 24, 2023
This is intended to revert some of the behaviour introduced in Jermolene#7835, see the discussion here: Jermolene#7888 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wikiparser.js parses text looking for a pragma block, it skips whitespace before looking for the next pragma. If no pragma is found, we should return the parse position to the original location so that the skipped whitespace can be parsed as a text node. This allows the attribute
join=" and "to parse as " and " (leading and trailing whitespace intact) rather than "and " (where the leading whitespace was skipped).