Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command line logging #3704

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Improve command line logging #3704

merged 3 commits into from
Jun 6, 2024

Conversation

Jermolene
Copy link
Owner

To fix #3703

@pmario
Copy link
Contributor

pmario commented Dec 13, 2023

@Jermolene -- Did you forget about this one and #3703

@Jermolene
Copy link
Owner Author

Thanks @pmario I had indeed forgotten about this one. I've added it to #7856

@Jermolene Jermolene merged commit 25ec52b into master Jun 6, 2024
1 check passed
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Jun 6, 2024 3:48pm

saqimtiaz added a commit to saqimtiaz/TiddlyWiki5 that referenced this pull request Jun 7, 2024
Jermolene added a commit that referenced this pull request Jun 7, 2024
@Jermolene
Copy link
Owner Author

I've reverted this PR because it seems to be incomplete – for example, it sets a prefix for the logger, but doesn't actually use it. More fundamentally, it doesn't resolve two significant problems:

  • That the commander.js uses a different logging mechanism than the syncer and the server
  • That there is no way to turn off the colour codes (we should probably automatically turn them off when outputting to a file rather than an interactive terminal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve command line logging
2 participants