Minor change to avoid duplicate error reporting

Stop processing when finding errors in emails and phone numbers. Change-Id: If2c43b3aa4bdeeb04b3c36082a13bcf3650b9213
JeroenDeDauw · Aug 21, 2012 · 8811190 · 8811190
1 parent 7411251
commit 8811190
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/includes/datavalues/SMW_DV_URI.php b/includes/datavalues/SMW_DV_URI.php
@@ -122,6 +122,7 @@ protected function parseUserValue( $value ) {
 					( preg_match( '<[-+./][-./]>', $hierpart ) ) ||
 					( !SMWURIValue::isValidTelURI( 'tel:' . $hierpart ) ) ) { /// TODO: introduce error-message for "bad" phone number
 					$this->addError( wfMsgForContent( 'smw_baduri', $this->m_wikitext ) );
+					return;
 				}
 				break;
 			case SMW_URI_MODE_EMAIL:
@@ -135,7 +136,7 @@ protected function parseUserValue( $value ) {
 				if ( !$check ) {
 					/// TODO: introduce error-message for "bad" email
 					$this->addError( wfMsgForContent( 'smw_baduri', $value ) );
-					break;
+					return;
 				}
 				$hierpart = str_replace( array( '%3A', '%2F', '%23', '%40', '%3F', '%3D', '%26', '%25' ), array( ':', '/', '#', '@', '?', '=', '&', '%' ), rawurlencode( $value ) );
 		}