Refactored Log.cs to a separate project #877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It won't run otherwise because other projects are configured for .NET 4.5.1
...to Logger project
Ironically, it was throwing a warning
...and replaced Console.WriteLine, where possible
I know that this change does not quite fit in this PR, but I thought that it is stupid to make a separate PR just for one line. Thanks @scholtzm!
| @@ -122,7 +125,7 @@ public bool DoLogin(string username, string password) | |||
| string steamGuardId = ""; | |||
| do | |||
| { | |||
| Console.WriteLine("SteamWeb: Logging In..."); | |||
| Log.Info("SteamWeb: Logging In..."); | |||
There was a problem hiding this comment.
This will cause a NullReferenceException, no? Log has never been assigned.
This change is needed because Log() requires parameters from Configuration.cs
...where needed
...and assigned Log
|
Rather than creating another project to hold the log configuration and creating a new Log instance in every class, why not just use a single static Log instance? |
|
That would be better, but due to some real life changes I can no longer work on this PR, sorry. If someone wants to resume where I left off, feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored Log.cs to a separate project called Logger.
I fixed all references and namespaces and I also replaced Console.WriteLine() in SteamTrade with Log functions accordingly.
Fixes #394.