New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging as a seperate subproject #394
Labels
Comments
IDK. Perhaps something more general? like |
Sounds good to me |
Would be nice to have. |
cwhelchel
added a commit
to cwhelchel/SteamBot
that referenced
this issue
Jan 22, 2014
Surround web call with a try...catch. The exception is silently ignored but needs to be logged. ref Jessecar96#394
Merged
IMHO there shouldn't even be a Log.cs because the built-in TraceSource already has all the functionalities our Log has. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Logging in the
ExampleBot
subproject is done through it'sLog
class.SteamTrade
can get their events printed in the trade manager console by throwing anOnError(string message)
event that aUserHandler
catches and runsOnTradeError([...])
on.There is no direct way to log events outside of
ExampleBot
, because that is the namespace whereLog.cs
resides.I have a working local branch where I put
Log.cs
into a separate subproject calledSteamBotLog
so that you can log from everywhere, as long as an instance of theLog
class is in scope. The drawback of this is that you have to change all your constructors to let you pass in aLog
.Is this worth committing?
The text was updated successfully, but these errors were encountered: