Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move component modification of output times #10

Conversation

WalterKolczynski-NOAA
Copy link

Description

The forecast hour list used to create the rocoto product metatasks were being made in the groups function instead of the forecast hour list function.

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Not

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

The forecast hour list used to create the rocoto product metatasks
were being made in the groups function instead of the forecast hour
list function.
@JessicaMeixner-NOAA
Copy link
Owner

Thanks @WalterKolczynski-NOAA since this isn't tested, I'm going to test before merging.

@JessicaMeixner-NOAA
Copy link
Owner

JessicaMeixner-NOAA commented Feb 20, 2024

@WalterKolczynski-NOAA I'm not getting the expected results.

My old xml: /scratch1/NCEPDEV/climate/Jessica.Meixner/HR3/outputupdate/testout01/EXPDIR/testout01/testout01.xml

we have:

        <var name="grp">_f006-f018 _f024-f036 _f042-f048</var>
        <var name="dep">f018 f036 f048</var>
        <var name="lst">f006_f012_f018 f024_f030_f036 f042_f048</var>

The new XML with this merged in: /scratch1/NCEPDEV/climate/Jessica.Meixner/HR3/outputupdate/testout02/EXPDIR/testout02/testout02.xml
we have:

        <var name="grp">_f003-f015 _f021-f033 _f039-f051 _f057-f069 _f075-f087 _f093-f105 _f111-f123</var>
        <var name="dep">f015 f033 f051 f069 f087 f105 f123</var>
        <var name="lst">f003_f009_f015 f021_f027_f033 f039_f045_f051 f057_f063_f069 f075_f081_f087 f093_f099_f105 f111_f117_f123</var>

so this is still going by 3s not 6s...

My g-w branch is here: /scratch1/NCEPDEV/climate/Jessica.Meixner/HR3/outputupdate/global-workflow

@WalterKolczynski-NOAA
Copy link
Author

Try again, should be fixed.

@JessicaMeixner-NOAA
Copy link
Owner

@WalterKolczynski-NOAA xml looks good now

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 1e46fc9 into JessicaMeixner-NOAA:feature/oceaniceout Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants